-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency repository when relocating #67
Comments
Hi @PhilKershaw The references to the sub-charts into the Chart.yaml are used mainly for 'pacakging' a new Helm chart. The scenario that Helm dt took into account is to have all the dependant Helm charts inside the "charts/" folder inside the main one. When installing the main chart, the the dependant charts installed comes from the local directory "charts/" that have been modified to use the proper registry. Are you bundling the Helm charts with the 'helm pack' command before running the 'helm dt' tool? |
Thanks for sharing the thinking behind the approach. I totally understand and in practice it mostly works out. Would there be any value in enabling an option to relocate dependency Helm Charts separately and not expecting them to be bundled? This would reduce duplication on the target registry side and possibly other benefits that don’t occur to me right now. To your question RE running |
|
It appears that this does not work if there are multiple layers of dependencies, e.g., chartA depends on chartB depends on chartC - chartC does not get relocated |
The previous implementation had a recursive function but it terminated after one level This branch adds support for nested repository urls - the previous implementation only supported a single level Resolves: vmware-labs#67
Is your feature request related to a problem? Please describe.
When relocating a Helm Chart with one of more dependencies the repository for said dependencies is not updated to the new location in the parent Chart.yaml. Meaning when installing the newly relocated parent chart it still pulls the original dependencies that contain the original image references.
Describe the solution you'd like
When relocating/unwrapping to a new repository the dependency repository references in Chart.yaml are updated to the new location. Thus, referencing the relocated subcharts that have references to the relocated images.
Describe alternatives you've considered
Besides manual intervention, no other alternatives considered.
Additional context
No response
The text was updated successfully, but these errors were encountered: