Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping CycloneDX and GGCR dependencies for webhook #103

Open
scothis opened this issue May 9, 2022 · 0 comments
Open

Consider dropping CycloneDX and GGCR dependencies for webhook #103

scothis opened this issue May 9, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@scothis
Copy link
Contributor

scothis commented May 9, 2022

Describe the feature request

CycloneDX and GGCR libraries exist at a specific version. The version used by the webhook library may differ from the version that a convention server wants to use. If either of these libraries ever makes a breaking change, then we'd be forcing a specific choice onto consumers. In both cases, the content will continue to exist, webhook servers can unmarshal the data into the same structs if it so desires, or can use some other struct.

The value the CycloneDX types is quite low and just a connivence method. It could be easily dropped and pushed fully into the convention server implementation.

Making the same change for GGCR is a bit more involved, but treating the OCI metadata as an opaque blob may be beneficial over assume that it has a specific structure.

Is your feature request related to a problem? Please describe

Describe alternatives you've considered

Additional context

These types of changes are very easy to make now, before an official release.

@scothis scothis added the enhancement New feature or request label May 9, 2022
@seagomezar seagomezar added this to the 0.4.2 milestone Apr 3, 2023
@rashedkvm rashedkvm removed this from the 0.4.2 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants