Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore ytt based conventions #58

Open
scothis opened this issue Mar 24, 2022 · 2 comments
Open

Explore ytt based conventions #58

scothis opened this issue Mar 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@scothis
Copy link
Contributor

scothis commented Mar 24, 2022

The current approach to defining an opinion source is via a webhook to a remote process. While flexible, this approach introduces networks and misconfigurations that can affect system stability. We should also explore ytt as a mechanism to run arbitrary code safely within the controller process.

Open questions:

  • can a poorly implemented convention cause a denial of service by crashing the controller?
  • does ytt offer a good programming model for users to author conventions?
  • can we provide a library of utility methods to make authoring a convention easier?

Proposed approach:

apiVersion: conventions.carto.run/v1alpha1
kind: ClusterPodConvention
metadata:
  name: ytt-sample
spec:
  ytt:
    template: |
      ...inlined ytt...

The .spec.webhook section would remain, but be mutually exclusive with .spec.ytt.

The structure being templated is the PodTemplateSpec, with image metadata exposed as a ytt value.

@scothis scothis added the enhancement New feature or request label Mar 24, 2022
@vrabbi
Copy link

vrabbi commented Jun 17, 2022

This would be amazing. I can think of a bunch of use cases this would solve for me and would be much easier to implement custom conventions

@cpage-pivotal
Copy link

Yes please! Being able to quickly implement template-based conventions with ytt is going to be extremely accessible to end users, and allow ops teams to realize enormous value from supply chains.

@seagomezar seagomezar added this to the 0.5.0 milestone Apr 3, 2023
@rashedkvm rashedkvm removed this from the 0.5.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants