Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tags for nested go modules as part of the release #63

Open
scothis opened this issue Mar 24, 2022 · 0 comments
Open

Create tags for nested go modules as part of the release #63

scothis opened this issue Mar 24, 2022 · 0 comments
Labels

Comments

@scothis
Copy link
Contributor

scothis commented Mar 24, 2022

When creating a release of cartographer-conventions, we need to create a tag. Part of the release is the webhook library that is a nested go modules. In order for go to resolve the nested module, we need to define an additional tag prefixed with the path of the modules. For a v0.0.0 tag, we also need to tag webhook/v0.0.0 for the same commit.

Currently, we create these tags manually, but it's annoying and there's always a chance we miss the step. Instead, we should create the extra tag in the release stage of CI. With #62 we no longer run CI for non-semver tags, so there's no risk of creating an infinite loop.

@scothis scothis added enhancement New feature or request chore and removed enhancement New feature or request labels Mar 24, 2022
@seagomezar seagomezar added this to the 0.4.2 milestone Apr 3, 2023
@rashedkvm rashedkvm removed this from the 0.4.2 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants