refactor error info

[zhengxiexie]

Now, log.Error is everywhere, both inside(service and utils module etc) and outside layer(controller module).
Suggest only putting err = fmt.Errorf("context info: %v", err) in inside layer, and not putting log.Error(err).
Put log.Error(err) in outside layer. In this way it could avoid much redundancy error info.

[zhengxiexie]

2023-11-27 04:31:47.522 ERROR securitypolicy/builder.go:78 failed to build rule and groups {"rule": {"action":"allow","direction":"in","ports":[{"protocol":"TCP","port":"web-port"}]}, "ruleIndex": 0, "error": "no pod has the corresponding named port"} github.com/vmware-tanzu/nsx-operator/pkg/nsx/services/securitypolicy.(*SecurityPolicyService).buildSecurityPolicy /root/nsx-operator/pkg/nsx/services/securitypolicy/builder.go:78 github.com/vmware-tanzu/nsx-operator/pkg/nsx/services/securitypolicy.(*SecurityPolicyService).DeleteSecurityPolicy /root/nsx-operator/pkg/nsx/services/securitypolicy/firewall.go:247 github.com/vmware-tanzu/nsx-operator/pkg/controllers/securitypolicy.(*SecurityPolicyReconciler).Reconcile /root/nsx-operator/pkg/controllers/securitypolicy/securitypolicy_controller.go:139 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile /root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:122 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler /root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:323 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem /root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 /root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235 2023-11-27 04:31:47.522 ERROR securitypolicy/firewall.go:250 failed to build nsx SecurityPolicy in deleting {"error": "no pod has the corresponding named port"} github.com/vmware-tanzu/nsx-operator/pkg/nsx/services/securitypolicy.(*SecurityPolicyService).DeleteSecurityPolicy /root/nsx-operator/pkg/nsx/services/securitypolicy/firewall.go:250 github.com/vmware-tanzu/nsx-operator/pkg/controllers/securitypolicy.(*SecurityPolicyReconciler).Reconcile /root/nsx-operator/pkg/controllers/securitypolicy/securitypolicy_controller.go:139 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile /root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:122 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler /root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:323 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem /root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 /root/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235