Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buildNSXVPC #748

Open
TaoZou1 opened this issue Sep 5, 2024 · 0 comments
Open

Refactor buildNSXVPC #748

TaoZou1 opened this issue Sep 5, 2024 · 0 comments

Comments

@TaoZou1
Copy link
Contributor

TaoZou1 commented Sep 5, 2024

currently buildNSXVPC also includes logic to check if vpc has been changed.
It's better to check if vpc changed then call buildNSXVPC like:
if vpcNeedUpdated {
createdVpc, err := buildNSXVPC(...)
}

it also uses:
if createdVpc == nil {
log.Info("no VPC changes detect, skip creating or updating process")
return existingVPC[0], nil
}

it's better to use vpcNeedUpdated instead of createdVpc == nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant