Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SubnetPort allocate address for DHCP #934

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

yanjunz97
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.44%. Comparing base (1cf8cb7) to head (57387a3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nsx/services/subnet/builder.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   73.38%   73.44%   +0.05%     
==========================================
  Files         109      109              
  Lines       15248    15270      +22     
==========================================
+ Hits        11190    11215      +25     
+ Misses       3307     3305       -2     
+ Partials      751      750       -1     
Flag Coverage Δ
unit-tests 73.44% <91.66%> (+0.05%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/subnetport/builder.go 76.51% <100.00%> (ø)
pkg/nsx/util/utils.go 64.31% <100.00%> (+0.69%) ⬆️
pkg/nsx/services/subnet/builder.go 86.20% <50.00%> (+2.87%) ⬆️

... and 2 files with indirect coverage changes

@yanjunz97 yanjunz97 force-pushed the dhcp-fix branch 4 times, most recently from 05622ca to c941108 Compare November 28, 2024 03:16
Copy link
Contributor

@wenqiq wenqiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@zhengxiexie zhengxiexie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yanjunz97 yanjunz97 merged commit 3663545 into vmware-tanzu:main Nov 29, 2024
2 checks passed
yanjunz97 added a commit to yanjunz97/nsx-operator that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants