From 4ae1fcf317cce0d23eec3a2d1f7348638b6c6d4c Mon Sep 17 00:00:00 2001 From: Xun Jiang Date: Mon, 17 Jul 2023 20:39:35 +0800 Subject: [PATCH] Improve backup log command UT coverage. Signed-off-by: Xun Jiang --- pkg/cmd/cli/backup/logs_test.go | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/pkg/cmd/cli/backup/logs_test.go b/pkg/cmd/cli/backup/logs_test.go index 9bb95a7a8d..12ef27bc0c 100644 --- a/pkg/cmd/cli/backup/logs_test.go +++ b/pkg/cmd/cli/backup/logs_test.go @@ -143,4 +143,24 @@ func TestNewLogsCommand(t *testing.T) { case <-done: } }) + + t.Run("Invalid client test", func(t *testing.T) { + // create a factory + f := &factorymocks.Factory{} + + kbClient := velerotest.NewFakeControllerRuntimeClient(t) + + f.On("Namespace").Return(cmdtest.VeleroNameSpace) + + c := NewLogsCommand(f) + assert.Equal(t, "Get backup logs", c.Short) + + l := NewLogsOptions() + flags := new(flag.FlagSet) + l.BindFlags(flags) + + f.On("KubebuilderClient").Return(kbClient, fmt.Errorf("test error")) + err := l.Complete([]string{""}, f) + require.Equal(t, "test error", err.Error()) + }) }