From 5059d169f57c867b9457d15ddcec967305255713 Mon Sep 17 00:00:00 2001 From: Mateus Oliveira Date: Thu, 28 Mar 2024 10:45:39 -0300 Subject: [PATCH] fixup! fix: Clean up golangci-lint config Signed-off-by: Mateus Oliveira --- .github/workflows/pr-linter-check.yml | 1 + site/content/docs/main/development.md | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/pr-linter-check.yml b/.github/workflows/pr-linter-check.yml index 28462fc1c6..4e6d58df5f 100644 --- a/.github/workflows/pr-linter-check.yml +++ b/.github/workflows/pr-linter-check.yml @@ -19,3 +19,4 @@ jobs: uses: golangci/golangci-lint-action@v3 with: version: v1.57.1 + skip-pkg-cache: true diff --git a/site/content/docs/main/development.md b/site/content/docs/main/development.md index ca3f865239..6c49160b37 100644 --- a/site/content/docs/main/development.md +++ b/site/content/docs/main/development.md @@ -30,6 +30,13 @@ You can run `make lint-fix` to fix fixable issues found by `make lint`. The linters, and their settings, are defined in the `.golangci.yaml` file. +Linting is enforced by the project CI through `.github/workflows/pr-linter-check.yml` job. + +To update `golangci-lint` used by the project, update: +- `with.version` of golangci/golangci-lint-action in `.github/workflows/pr-linter-check.yml:21` +- `golangci-lint` version installed in build-image in `hack/build-image/Dockerfile:96` +- documentation reference comment in `.golangci.yaml:1` + ## Test To run unit tests, use `make test`.