Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated snapshot ID recording/retrieving method for pod volume backup #5277

Closed
Lyndon-Li opened this issue Sep 2, 2022 · 8 comments
Assignees

Comments

@Lyndon-Li
Copy link
Contributor

Lyndon-Li commented Sep 2, 2022

In the current code (getVolumeBackupInfoForPod), we have two ways to retrieve the snapshot ID for a PVB, one is to get it from the PVB's status, the other is to get it from the pod's annotation. This means, there are two ways to saving the snapshot ID for a PVB, to the PVB's status or to the pod's annotation.

The latter way seems to be used by very old releases and we are not using it in the latest code.

Therefore, let's check and see if we can remove the latter way as it has been deprecated for a long time.

The deprecation message was added in v1.0.1 by PR #1577

@stale
Copy link

stale bot commented Nov 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Nov 19, 2022
@Lyndon-Li Lyndon-Li removed the staled label Nov 20, 2022
@stale
Copy link

stale bot commented Jan 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Jan 20, 2023
@stale
Copy link

stale bot commented Feb 11, 2023

Closing the stale issue.

@stale stale bot closed this as completed Feb 11, 2023
@Lyndon-Li Lyndon-Li removed the staled label Feb 13, 2023
@Lyndon-Li Lyndon-Li reopened this Feb 13, 2023
@stale
Copy link

stale bot commented May 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label May 1, 2023
@Lyndon-Li Lyndon-Li removed the staled label May 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@github-actions github-actions bot added the staled label Jul 3, 2023
@Lyndon-Li Lyndon-Li removed the staled label Jul 3, 2023
@Lyndon-Li
Copy link
Contributor Author

Not stale

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@github-actions github-actions bot added the staled label Sep 2, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 14 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant