[On Hold] Proposal to add generic pluginInputs field in backup/restore/schedule CRs #5981
Conversation
Signed-off-by: Anshul Ahuja <[email protected]>
Signed-off-by: Anshul Ahuja <[email protected]>
Signed-off-by: Anshul Ahuja <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5981 +/- ##
==========================================
- Coverage 40.14% 39.96% -0.19%
==========================================
Files 249 256 +7
Lines 22029 23037 +1008
==========================================
+ Hits 8843 9206 +363
- Misses 12541 13139 +598
- Partials 645 692 +47 see 46 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| ```yaml | ||
| spec: | ||
| pluginInputs: | ||
| - name: velero.io/storageclass |
There was a problem hiding this comment.
Is the name field used to represent the plugin's name?
If so, the name should be velero.io/change-storage-class.
| name: backup-1 | ||
| spec: | ||
| pluginInputs: | ||
| - name: velero.io/csi |
There was a problem hiding this comment.
The plugin name should be velero.io/csi-volumesnapshot-backupper.
I also wonder if the configuration is applied to many plugins, and we can only choose the plugin by name, then this gonna be a long list.
Could we consider adding some RE function here?
| pluginInputs: | ||
| - name: velero.io/csi | ||
| - properties: | ||
| - key: csi.cloud.disk.driver |
There was a problem hiding this comment.
I think the format should be
- properties:
- csi.cloud.disk.driver: csi-diskdriver-snapclass
- csi.cloud.file.driver: csi-filedriver-snapclass
|
@blackpiglet thanks for going through this PR and providing feedback, currently this PR is on hold since we could not get agreement from community for implementing this. I'll address your comments in case in future we pick it again. |
anshulahuja98
changed the title
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.