Mark dataupload/datadownload in cancel when velero pod restart

[qiuming-best]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)
#6127
#6126

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
• Updated the corresponding documentation in site/content/docs/main.

[codecov-commenter]

Codecov Report

Merging #6461 (480fe44) into main (e54a8af) will decrease coverage by 0.29%.
The diff coverage is 33.01%.

@@            Coverage Diff             @@
##             main    #6461      +/-   ##
==========================================
- Coverage   60.18%   59.90%   -0.29%     
==========================================
  Files         229      229              
  Lines       24215    24397     +182     
==========================================
+ Hits        14575    14616      +41     
- Misses       8632     8767     +135     
- Partials     1008     1014       +6     

Impacted Files	Coverage Δ
pkg/cmd/cli/nodeagent/server.go	9.45% <0.00%> (-1.84%)	⬇️
pkg/cmd/server/server.go	21.87% <42.85%> (+0.99%)	⬆️
pkg/controller/data_download_controller.go	71.06% <43.33%> (-6.11%)	⬇️
pkg/controller/data_upload_controller.go	62.02% <43.85%> (-4.03%)	⬇️

... and 2 files with indirect coverage changes

[blackpiglet]

Just a quick question, why do both node-agent and the Velero server need the DataUpload and DataDownload cancel logic? Looks like there is some overlap.

[qiuming-best]

@blackpiglet > Just a quick question, why do both node-agent and the Velero server need the DataUpload and DataDownload cancel logic? Looks like there is some overlap.

As our DataUpload and DataDownload are different from other CRDs in that they are Backup and Restore CRDs related, their restart handling logic are little more complicated.
This means :

• if Backup and Restore CRDs failed, the related DataUpload and DataDownload must be also terminated(As per our design doc, it would be Canceled). (Velero server restart)
• if DataUpload and DataDownload are terminated(As per our design doc, it would be Canceled), Backup and Restore CRDs should be partially failed. (node-agent restart)

So we need to handle both node-agent and Velero server restart.