Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore ingresses after services #6639

Closed
wants to merge 2 commits into from

Conversation

27149chen
Copy link
Contributor

@27149chen 27149chen commented Aug 10, 2023

Please add a summary of your change

restore ingresses after services to avoid ingress webhook failure caused by validation that if corresponding service exists

Does your change fix a particular issue?

N/A

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #6639 (96d7f72) into main (a88cb46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6639   +/-   ##
=======================================
  Coverage   60.18%   60.18%           
=======================================
  Files         242      242           
  Lines       25711    25711           
=======================================
  Hits        15474    15474           
  Misses       9156     9156           
  Partials     1081     1081           
Files Changed Coverage Δ
pkg/cmd/server/server.go 21.91% <ø> (ø)

Signed-off-by: lou <[email protected]>
@reasonerjt
Copy link
Contributor

reasonerjt commented Aug 14, 2023

Is there a concrete example of such webhook?

Labeling it as defer-candidate as it may be out of v1.12.0 release.

@27149chen
Copy link
Contributor Author

Is there a concrete example of such webhook?

Labeling it as defer-candidate as it may be out of v1.12.0 release.

found a related issue #5068

@reasonerjt
Copy link
Contributor

That issue indicates ANY resources that requires admission webhook should be restored after service.

And this change is probably not needed because the service has been put in the "high priority list" and it's already restored before ingress.

@27149chen
Copy link
Contributor Author

I see, thanks, closing it.

@27149chen 27149chen closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants