Skip to content

Refactor the schedule cases#8430

Merged
kaovilai merged 1 commit intovelero-io:mainfrom
blackpiglet:8323_fix
Nov 25, 2024
Merged

Refactor the schedule cases#8430
kaovilai merged 1 commit intovelero-io:mainfrom
blackpiglet:8323_fix

Conversation

@blackpiglet
Copy link
Copy Markdown
Contributor

@blackpiglet blackpiglet commented Nov 19, 2024

Thank you for contributing to Velero!

Please add a summary of your change

  • Modify the OrderResource case's verification code.
  • Simplify the Periodic case.
  • Simplify the InProgess case.
  • Prettify the code.
  • Replace math/rand with crypto/rand
  • Replace PollUnitl with PollUntilContextTimeout

Does your change fix a particular issue?

Please indicate you've done the following:

@blackpiglet blackpiglet added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes and removed has-e2e-2tests labels Nov 19, 2024
@blackpiglet blackpiglet marked this pull request as draft November 19, 2024 07:11
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.98%. Comparing base (9f0026d) to head (226d50d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8430   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files         368      368           
  Lines       39000    39000           
=======================================
  Hits        23004    23004           
  Misses      14532    14532           
  Partials     1464     1464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet force-pushed the 8323_fix branch 10 times, most recently from ab82952 to 1e9b204 Compare November 21, 2024 02:37
@blackpiglet blackpiglet marked this pull request as ready for review November 21, 2024 02:38
@github-actions github-actions bot requested a review from Lyndon-Li November 21, 2024 02:38
* Modify the OrderResource case's verification code.
* Simplify the Periodical case.
* Simplify the InProgess case.
* Prettify the code.
* Replace math/rand with crypto/rand
* Replace PollUnitl with PollUntilContextTimeout

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
@blackpiglet blackpiglet changed the title 8323 fix Refactor the schedule cases Nov 22, 2024
@kaovilai kaovilai merged commit af85b7d into velero-io:main Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants