Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use absolute path for reading manifest #3551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use absolute path for reading manifest #3551

wants to merge 1 commit into from

Conversation

Xiol
Copy link

@Xiol Xiol commented Sep 18, 2024

Description

Closes: #3550

Ensure the absolute path to the manifest is used.

Also stops any error from being printed on stderr.

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Test case added.

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@vmwclabot
Copy link
Member

@Xiol, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@Xiol, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@Xiol Xiol force-pushed the issue-3550-readmanifest-abs-path branch 3 times, most recently from bc5818a to bd8f0c6 Compare September 20, 2024 08:24
@Xiol Xiol force-pushed the issue-3550-readmanifest-abs-path branch from bd8f0c6 to 60f2a6e Compare September 23, 2024 08:26
@Xiol
Copy link
Author

Xiol commented Sep 23, 2024

Apologies to the maintainer that keeps allowing the CI to run only for it to fail. I think I've got it this time!

dougm
dougm approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xiol , lgtm. We can merge when clabot approves.

@vmwclabot
Copy link
Member

@Xiol, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

@luisdavim luisdavim luisdavim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] importer.ReadManifest() attempts to read from relative path
4 participants
@Xiol @vmwclabot @dougm @luisdavim