pytests: Add conftest.py and other tests #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverkurth
requested changes
Aug 28, 2024
pytest/test_raw_image_option.py
Outdated
Comment on lines
62
to
78
| in_yaml = os.path.join(CONFIG_DIR, "raw-image.yaml") | ||
|
|
||
| basename = os.path.basename(in_yaml.rsplit(".", 1)[0]) | ||
| out_ovf = os.path.join(WORK_DIR, f"{basename}.ovf") | ||
|
|
||
| process = subprocess.run([OVA_COMPOSE, "-i", in_yaml, "-o", out_ovf, "--vmdk-convert", VMDK_CONVERT], cwd=WORK_DIR) | ||
| assert process.returncode == 0 | ||
|
|
||
| with open(in_yaml) as f: | ||
| yaml_loader = yaml.SafeLoader | ||
| yaml_loader.app_params = {} | ||
| yaml.add_constructor("!param", yaml_param, Loader=yaml_loader) | ||
| config = yaml.load(f, Loader=yaml_loader) | ||
|
|
||
| with open(out_ovf) as f: | ||
| ovf = xmltodict.parse(f.read()) | ||
|
|
There was a problem hiding this comment.
This code is also in test_all_configs.py, so I think this should be in a common file.
pytest/test_raw_image_option.py
Outdated
| with open(out_ovf) as f: | ||
| ovf = xmltodict.parse(f.read()) | ||
|
|
||
| test_all_configs.test_envelope_configs((config, ovf)) |
There was a problem hiding this comment.
I don't really like invoking a function in another test_*.py file - so I think test_envelope_configs shopuld be in a separate file, that is imported by both test_all_configs.py and test_raw_image_option.py.
prashant1221
force-pushed
the
master
branch
from
341d2b8
to
b1cd8d0
Compare
prashant1221
force-pushed
the
master
branch
from
b1cd8d0
to
5007250
Compare
conftest.py contain common fixtures to setup and teardown. We use them wherever feasible Added Configurations and Hardware section tests in tests_all_configs. It tests the keys present under those section in our config file. pytest/test_raw_image_option.py checks .img if provided instead of vmdk should still work. After that it matches values for the same in ovf and our yaml.
prashant1221
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conftest.py contain common fixtures to setup and teardown.
We use them wherever feasible
Added Configurations and Hardware section tests in tests_all_configs.
It tests the keys present under those section in our config file.
pytest/test_raw_image_option.py checks .img if provided instead
of vmdk should still work.
After that it matches values for the same in ovf and our yaml.