Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSX-T Edges BGP peer password requirement. #146

Closed
4 tasks done
vincenthanjs opened this issue Apr 2, 2024 · 2 comments
Closed
4 tasks done

NSX-T Edges BGP peer password requirement. #146

vincenthanjs opened this issue Apr 2, 2024 · 2 comments
Assignees
@dimitarproynov
Labels
enhancement Enhancement pending-review Pending Review

Comments

@vincenthanjs
Copy link

Code of Conduct

  • I have read and agree to the project's Code of Conduct.
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

Understand there is a validation check for BGP peer password for NSX-T Edges. Could you please remove this validation? Some of the customer environment do not use BGP password.

Use Case(s)

No BGP Password.

Potential Configuration

password=""

References

No response
@vincenthanjs vincenthanjs added enhancement Enhancement needs-review Needs Review labels Apr 2, 2024
@github-actions github-actions bot added the pending-review Pending Review label Apr 2, 2024
@vincenthanjs vincenthanjs changed the title BGP peer password requirement. NSX-T Edges BGP peer password requirement. Apr 2, 2024
@spacegospod spacegospod self-assigned this Apr 2, 2024
dimitarproynov pushed a commit that referenced this issue Apr 3, 2024
Remove BGP peer password requirement
e393d6e 
Clients of VCF have a use-case where the BGP peer password is not used.

#146

Testing done:
make test
make build
make lint

Signed-off-by: Dimitar Proynov <[email protected]>
@dimitarproynov dimitarproynov mentioned this issue Apr 3, 2024
Merged
11 tasks
@dimitarproynov
Copy link
Contributor

The fix is merged, will be released with next release.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dimitarproynov dimitarproynov

Labels
enhancement Enhancement pending-review Pending Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tenthirtyam @vincenthanjs @dimitarproynov @spacegospod