Skip to content

Commit b6c74c3

Browse files
author
Tao Jiang
authored
Fix the broken integrationt test (#48)
The #47 move zap into its own packge but it also breaks the integration test. This change is to fix integ test by correcting its package reference. Signed-off-by: Tao Jiang <[email protected]>
1 parent 5756109 commit b6c74c3

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

test/logger_test.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
"testing"
2929

3030
"github.com/vmware/vmware-go-kcl/logger"
31+
zaplogger "github.com/vmware/vmware-go-kcl/logger/zap"
3132
)
3233

3334
func TestZapLoggerWithConfig(t *testing.T) {
@@ -41,7 +42,7 @@ func TestZapLoggerWithConfig(t *testing.T) {
4142
Filename: "log.log",
4243
}
4344

44-
log := logger.NewZapLoggerWithConfig(config)
45+
log := zaplogger.NewZapLoggerWithConfig(config)
4546

4647
contextLogger := log.WithFields(logger.Fields{"key1": "value1"})
4748
contextLogger.Debugf("Starting with zap")
@@ -52,7 +53,7 @@ func TestZapLogger(t *testing.T) {
5253
zapLogger, err := zap.NewProduction()
5354
assert.Nil(t, err)
5455

55-
log := logger.NewZapLogger(zapLogger.Sugar())
56+
log := zaplogger.NewZapLogger(zapLogger.Sugar())
5657

5758
contextLogger := log.WithFields(logger.Fields{"key1": "value1"})
5859
contextLogger.Debugf("Starting with zap")

test/worker_test.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import (
3838
"github.com/vmware/vmware-go-kcl/clientlibrary/utils"
3939
wk "github.com/vmware/vmware-go-kcl/clientlibrary/worker"
4040
"github.com/vmware/vmware-go-kcl/logger"
41+
zaplogger "github.com/vmware/vmware-go-kcl/logger/zap"
4142
)
4243

4344
const (
@@ -109,7 +110,7 @@ func TestWorkerWithSigInt(t *testing.T) {
109110
// At miminal. use standard zap logger
110111
//zapLogger, err := zap.NewProduction()
111112
//assert.Nil(t, err)
112-
//log := logger.NewZapLogger(zapLogger.Sugar())
113+
//log := zaplogger.NewZapLogger(zapLogger.Sugar())
113114
//
114115
// In order to have precise control over logging. Use logger with config.
115116
config := logger.Configuration{
@@ -122,7 +123,7 @@ func TestWorkerWithSigInt(t *testing.T) {
122123
Filename: "log.log",
123124
}
124125
// use zap logger
125-
log := logger.NewZapLoggerWithConfig(config)
126+
log := zaplogger.NewZapLoggerWithConfig(config)
126127

127128
kclConfig := cfg.NewKinesisClientLibConfig("appName", streamName, regionName, workerID).
128129
WithInitialPositionInStream(cfg.LATEST).

0 commit comments

Comments
 (0)