diff --git a/crates/vite_error/src/lib.rs b/crates/vite_error/src/lib.rs index 09f23ed57e..7ecb20955b 100644 --- a/crates/vite_error/src/lib.rs +++ b/crates/vite_error/src/lib.rs @@ -11,7 +11,7 @@ pub enum Error { #[error(transparent)] Io(#[from] std::io::Error), - #[error("IO error: {err} at {path:?}")] + #[error("IO error: {err} at {}", .path.as_path().display())] IoWithPath { err: std::io::Error, path: Arc }, #[error(transparent)] @@ -66,7 +66,7 @@ pub enum Error { #[error("Resolve universal vite config failed")] ResolveUniversalViteConfigFailed { status: Str, reason: Str }, - #[error("The path ({path:?}) is not a valid relative path because: {reason}")] + #[error("The path ({}) is not a valid relative path because: {reason}", .path.display())] InvalidRelativePath { path: Box, reason: FromPathError }, #[error("Unsupported package manager: {0}")] @@ -79,7 +79,8 @@ pub enum Error { UnrecognizedPackageManager, #[error( - "Package manager {name}@{version} in {package_json_path:?} is invalid, expected format: 'package-manager-name@major.minor.patch'" + "Package manager {name}@{version} in {} is invalid, expected format: 'package-manager-name@major.minor.patch'", + .package_json_path.as_path().display() )] PackageManagerVersionInvalid { name: Str, version: Str, package_json_path: AbsolutePathBuf }, diff --git a/crates/vite_global_cli/src/commands/global/install.rs b/crates/vite_global_cli/src/commands/global/install.rs index 0b09e52493..d2618c5314 100644 --- a/crates/vite_global_cli/src/commands/global/install.rs +++ b/crates/vite_global_cli/src/commands/global/install.rs @@ -557,9 +557,7 @@ async fn install_one( } let _ = std::io::stderr().write_all(&output.stderr); cleanup_failed_install(&install_dir).await?; - return Err(Error::Other( - format!("npm install failed with exit code: {:?}", output.status.code()).into(), - )); + return Err(Error::Other(format!("npm install failed with {}", output.status).into())); } let node_modules_dir = get_node_modules_dir(&install_dir, package_name); diff --git a/packages/cli/snap-tests-global/command-env-global-install-multiple-fail/snap.txt b/packages/cli/snap-tests-global/command-env-global-install-multiple-fail/snap.txt index 9ea8f4dde5..e748ae56f8 100644 --- a/packages/cli/snap-tests-global/command-env-global-install-multiple-fail/snap.txt +++ b/packages/cli/snap-tests-global/command-env-global-install-multiple-fail/snap.txt @@ -11,7 +11,7 @@ npm error A complete log of this run can be found in: /.npm/_logs/