Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on #846 #1243

Closed
3 of 4 tasks
trungleduc opened this issue Oct 27, 2022 · 5 comments
Closed
3 of 4 tasks

Follow-up on #846 #1243

trungleduc opened this issue Oct 27, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@trungleduc
Copy link
Member

trungleduc commented Oct 27, 2022

Reposted from #846

@trungleduc trungleduc added the enhancement New feature or request label Oct 27, 2022
@trungleduc trungleduc added this to the 1.0.0 milestone Oct 27, 2022
@jtpio
Copy link
Member

jtpio commented Oct 27, 2022

We should also consider updating to the latest @jupyterlab packages and leverage the changes to ServiceManager as discussed in #846 (review).

Updating the top post to add this item.

@bollwyvl
Copy link
Contributor

Load JupyterLab extensions from the CDN?

Please, whatever happens, make CDN opt-in, providing a robust way to serve a known list of locally-available extensions, so that a they can be deployed along with a voila deployment. Reliance on (or having to co-deploy) a CDN is the cause of many issues when trying to actually own a non-public jupyter stack, and the well-understood scope and directory layout of prebuilt labextensions makes it far easier to manage than the previous requirejs mess.

To account for versioning, it might even be possible to serve directly from a pile of not-installed .whl or .tar.bz2 packages, as the precise location of the assets would be known in advance. I'm not sure how notebooks would advertise these versions, but this seems like an important, higher-order concern, and maybe not something voila can solve unilaterally.

Support JupyterLab themes

Yes. Encouraging folk to author in a theme environment consistent with their deployment is huge.

@martinRenou
Copy link
Member

martinRenou commented Oct 27, 2022

Support JupyterLab themes

Yes. Encouraging folk to author in a theme environment consistent with their deployment is huge.

Just adding a note that jupyterlab themes are actually already supported :D Though we don't support yet dynamically switching themes in the front-end.

@bollwyvl
Copy link
Contributor

dynamically switching themes in the front-end.

That's probably good for most deployment use cases.

@martinRenou martinRenou modified the milestones: 1.0.0, 0.5.0 Oct 28, 2022
@trungleduc
Copy link
Member Author

Closing as Load JupyterLab extensions from the CDN? Requires upstream feature for dynamic extensions? is not feasible in 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants