Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack 5 Asset Modules #1305

Closed
jtpio opened this issue Mar 16, 2023 · 5 comments · Fixed by #1354
Closed

Update to webpack 5 Asset Modules #1305

jtpio opened this issue Mar 16, 2023 · 5 comments · Fixed by #1354
Labels
enhancement New feature or request
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Mar 16, 2023

Problem

Currently the @voila-dashboards/voila package depends on Webpack 5:

"webpack": "^5.24.1",

In Webpack 5 most of the url-loader, file-loader and others have been deprecated in favor of the Asset Modules: https://webpack.js.org/guides/asset-modules/

Proposed Solution

We should check if Voila could drop some of the dependencies on the old loaders:

"file-loader": "^6.2.0",

"url-loader": "^4.1.1",

Additional context

For reference JupyterLab implemented this change in jupyterlab/jupyterlab#12350

@jtpio jtpio added the enhancement New feature or request label Mar 16, 2023
@jtpio jtpio added this to the 0.5.0 milestone Mar 16, 2023
@jtpio
Copy link
Member Author

jtpio commented Mar 16, 2023

This might also be relevant for #1304

@maartenbreddels
Copy link
Member

@mariobuikhuizen is this important for ipyvuetify ? since you had some issues with the fonts?

@martinRenou
Copy link
Member

This could probably go into a 0.5.1 release? Should we remove it from the 0.5.0 milestone?

@jtpio
Copy link
Member Author

jtpio commented Jul 26, 2023

Probably the only impact would be for extension authors that expect these loaders to be there, which is why it would have been nice to clean that up for the next major release.

Although in the case of Voila the impact would probably be limited as widgets and mime renderers usually don't care about these details.

@trungleduc
Copy link
Member

👍 on delivering this change on 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants