Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.x: Fix markdown rendering logic #1491

Merged
merged 11 commits into from
Oct 9, 2024

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Sep 23, 2024

Using the following code:

from ipywidgets import Output

from IPython.display import display, Markdown

out = Output()

with out:
    display(Markdown("[google](https://google.com)"))

out

Results in not rendering the link properly, instead we see the raw code inlined "[google](https://google.com)"

This PR fixes that issue.

Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/fix_markdown_render

@martinRenou martinRenou added the bug Something isn't working label Oct 1, 2024
@martinRenou
Copy link
Member Author

The PR correctly fixes the example above, but it seems to break mathematical expressions:

Screenshot from 2024-10-03 16-45-24

I also see this issue on Voila 0.5.x so this looks like a regression from updating to this new logic of handling mathjax.

@martinRenou martinRenou marked this pull request as ready for review October 8, 2024 18:14
@martinRenou
Copy link
Member Author

This is working now 🚀

@martinRenou martinRenou requested a review from jtpio October 9, 2024 14:53
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 1ad78a3 into voila-dashboards:0.4.x Oct 9, 2024
16 of 23 checks passed
@martinRenou martinRenou deleted the fix_markdown_render branch October 9, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants