Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More strict php dependency #18

Open
siemendev opened this issue Jan 21, 2022 · 1 comment
Open

More strict php dependency #18

siemendev opened this issue Jan 21, 2022 · 1 comment

Comments

@siemendev
Copy link

Hi folks,
as we learned from #16 (comment), It's extremely risky to depend on "php": ">=7.0.0" since there may be changes in future php versions that (once again) stop this lib from working although composer says that it works with the installed php version.

I suggest "php": "^7.0|^8.0" (adding the 8.0 assuming #17 has been merged by the time this issue is viewed).

Great work guys, keep it up :-)

@voku
Copy link
Owner

voku commented Jan 21, 2022

The problem is (I think) that composer will install an old version in this case. 😑

I was jung and thought I will maintain the lib anyway, so I don't need to use strict php versions. But in the meantime I switched the job, became 2x dad... how the time flies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants