Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CtxRequestIDLogger is a bad name #2

Closed
bradj opened this issue Jan 9, 2017 · 1 comment
Closed

CtxRequestIDLogger is a bad name #2

bradj opened this issue Jan 9, 2017 · 1 comment

Comments

@bradj
Copy link

bradj commented Jan 9, 2017

https://github.com/nullbio/abcweb/blob/67901e361869af4197c8b1d6494d4a391207289f/templates/middleware/middleware.go.tmpl#L7

It's a value for lookup. I propose CtxLogLookup.
@nullbio
Copy link
Member

nullbio commented Jan 10, 2017

Sure, I'll change it. Thanks.

@nullbio nullbio closed this as completed Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradj @nullbio