Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should use Middleware2 function not Middleware #301

Closed
ibraheemdev opened this issue Aug 8, 2020 · 1 comment
Closed

Tests should use Middleware2 function not Middleware #301

ibraheemdev opened this issue Aug 8, 2020 · 1 comment

Comments

@ibraheemdev
Copy link
Contributor

No description provided.

@aarondl
Copy link
Member

aarondl commented Aug 10, 2020

There is no reason for this. It should be corrected. Good catch and a good first contributor issue.

@aarondl aarondl changed the title Why do all the tests still use the Middleware function when it was deprecated in favour of Middleware2? Tests should use Middleware2 function not Middleware Aug 10, 2020
@ibraheemdev ibraheemdev mentioned this issue Aug 14, 2020
Merged
@aarondl aarondl closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aarondl @ibraheemdev