Skip to content

Commit 45cd6c1

Browse files
authored
[DataFusion] Don't pushdown empty filters (#5264)
Taken out of #5205, I think we might hit [this](apache/datafusion#18513) issue otherwise, and this also just make sense generally? Signed-off-by: Adam Gutglick <[email protected]>
1 parent 7541a3b commit 45cd6c1

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

vortex-datafusion/src/persistent/source.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,12 @@ impl FileSource for VortexSource {
230230
filters: Vec<Arc<dyn PhysicalExpr>>,
231231
_config: &ConfigOptions,
232232
) -> DFResult<FilterPushdownPropagation<Arc<dyn FileSource>>> {
233+
if filters.is_empty() {
234+
return Ok(FilterPushdownPropagation::with_parent_pushdown_result(
235+
vec![],
236+
));
237+
}
238+
233239
let Some(schema) = self.arrow_file_schema.as_ref() else {
234240
return Ok(FilterPushdownPropagation::with_parent_pushdown_result(
235241
vec![PushedDown::No; filters.len()],

0 commit comments

Comments
 (0)