Skip to content

Commit f59147e

Browse files
committed
add dummy scale_factor flag for fineweb to please CI
Signed-off-by: Andrew Duffy <[email protected]>
1 parent ff356d4 commit f59147e

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

bench-vortex/src/bin/query_bench.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,10 @@ struct FinewebArgs {
222222
]
223223
)]
224224
targets: Vec<Target>,
225+
226+
// Dummy, unused but we are required to accept it to make the CI automation happy
227+
#[arg(long)]
228+
scale_factor: u64,
225229
}
226230

227231
fn validate_scale_factor(val: &str) -> Result<String, String> {

bench-vortex/src/engines/ddb/mod.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use std::path::PathBuf;
55
use std::time::{Duration, Instant};
66

77
use anyhow::Result;
8-
use log::{info, trace};
8+
use log::trace;
99
use url::Url;
1010
use vortex::error::VortexExpect;
1111
use vortex_duckdb::duckdb::{Config, Connection, Database};
@@ -164,7 +164,7 @@ impl DuckDBCtx {
164164

165165
// Generate and execute table registration commands
166166
let commands = self.generate_table_commands(&effective_url, extension, dataset, object);
167-
info!("Executing table registration commands: {commands}");
167+
trace!("Executing table registration commands: {commands}");
168168
self.execute_query(&commands)?;
169169

170170
Ok(())
@@ -200,9 +200,7 @@ impl DuckDBCtx {
200200
) -> String {
201201
// Base path contains trailing /.
202202
let base_dir = base_url.as_str();
203-
info!("base_dir1: {base_dir}");
204203
let base_dir = base_dir.strip_prefix("file://").unwrap_or(base_dir);
205-
info!("base_dir2: {base_dir}");
206204
match dataset {
207205
BenchmarkDataset::TpcH { .. } => {
208206
let mut commands = String::new();

bench-vortex/src/fineweb/mod.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,10 @@ impl Benchmark for Fineweb {
9494
fn generate_data(&self, target: &Target) -> anyhow::Result<()> {
9595
// Before downloading anything, make sure we are using a supported target.
9696
anyhow::ensure!(
97-
matches!(target.format, Format::Parquet | Format::OnDiskVortex),
97+
matches!(
98+
target.format,
99+
Format::Parquet | Format::OnDiskVortex | Format::VortexCompact
100+
),
98101
"unsupported format for `fineweb` bench: {}",
99102
target.format
100103
);

0 commit comments

Comments
 (0)