From f87f6080ed5bcd034a17c7531a3ac46f2c28a5d1 Mon Sep 17 00:00:00 2001 From: Marcin Slezak Date: Fri, 19 Apr 2024 16:42:55 +0200 Subject: [PATCH] fixes for CustomerRedeemables endpoint: - types names following CONTRIBUTING.md - add missing voucher.gift.effect - adding missing voucher.loyalty_card.next_expiration_date and voucher.loyalty_card.next_expiration_points - adding missing voucher.redemption.redeemed_points - voucher.active as optional field --- packages/sdk/src/types/Customers.ts | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/packages/sdk/src/types/Customers.ts b/packages/sdk/src/types/Customers.ts index ed19ec246..aae235824 100644 --- a/packages/sdk/src/types/Customers.ts +++ b/packages/sdk/src/types/Customers.ts @@ -134,12 +134,12 @@ export interface CustomerRedeemablesListResponse { object: 'list' total: number data_ref: 'data' - data: CustomerRedeemable[] + data: CustomerRedeemablesListItemResponse[] has_more: boolean more_starting_after?: string } -export interface CustomerRedeemable { +export interface CustomerRedeemablesListItemResponse { id: string created_at: string redeemable_id: string @@ -149,10 +149,10 @@ export interface CustomerRedeemable { campaign_id: string campaign_type: 'LOYALTY_PROGRAM' | 'PROMOTION' | 'DISCOUNT_COUPONS' | 'GIFT_VOUCHERS' | 'REFERRAL_PROGRAM' voucher_type: 'GIFT_VOUCHER' | 'DISCOUNT_VOUCHER' | 'LOYALTY_CARD' - redeemable: RedeemableContainer + redeemable: CustomerRedeemablesListItemContainerResponse } -export interface RedeemableContainerVoucher { +export interface CustomerRedeemablesListItemContainerVoucherResponse { id: string code: string campaign?: string @@ -163,10 +163,13 @@ export interface RedeemableContainerVoucher { gift?: { amount: number balance: number + effect: string } loyalty_card?: { points: number balance: number + next_expiration_date?: string + next_expiration_points?: number } start_date?: string expiration_date?: string @@ -185,8 +188,9 @@ export interface RedeemableContainerVoucher { quantity?: number redeemed_quantity: number url: string + redeemed_points?: number } - active: boolean + active?: boolean additional_info?: string metadata?: Record assets: { @@ -206,9 +210,9 @@ export interface RedeemableContainerVoucher { object: 'voucher' } -export interface RedeemableContainer { +export interface CustomerRedeemablesListItemContainerResponse { type: 'voucher' - voucher?: RedeemableContainerVoucher + voucher?: CustomerRedeemablesListItemContainerVoucherResponse status: 'ACTIVE' | 'USED' | 'DISABLED' | 'NOT_ACTIVE' | 'EXPIRED' | 'NO_BALANCE' }