Skip to content

Conversation

@jay7x
Copy link
Member

@jay7x jay7x commented Apr 29, 2025

Previously, the example was using the TOML-inspired syntax instead of proper Hash usage. The 'toml' gem supports both in its Generator.

Previously, the example was using the TOML-inspired syntax instead of
proper Hash usage. The 'toml' gem supports both in its Generator.
@jay7x
Copy link
Member Author

jay7x commented Apr 29, 2025

There is one drawback I can foresee..

This hides the fact, that most of installations before this still have TOML "dotted keys" in their configs. So when someone will try to convert this module to stdlib::to_toml() again, they will see no problems anymore. But all existing installations will be broken (because to_toml() doesn't support dotted keys and renders broken TOML in that case).

@jay7x jay7x closed this May 1, 2025
@jay7x jay7x reopened this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant