Better error management

Author: vrde

cli.js

@@ -34,7 +34,7 @@ program
   .option(
     "-e, --execute <command>",
     "Start ethnode, execute command, and exit ethnode (useful for testing)."
-  )
+  );
 
 program.version(packageJson.version);
 

get_geth.sh

@@ -3,12 +3,16 @@
 
 # Note: $HOMEDIR is defined in main.js, check it out
 
+set -e
+
 PLATFORM=$(uname | tr '[:upper:]' '[:lower:]')
 ARCH=$(uname -m)
 
 VERSION=$(curl -s https://api.github.com/repos/ethereum/go-ethereum/releases/latest | python -c "import sys, json; print(json.load(sys.stdin)['tag_name'])")
 COMMIT=$(curl -s https://api.github.com/repos/ethereum/go-ethereum/commits/${VERSION} | python -c "import sys, json; print(json.load(sys.stdin)['sha'])")
 NAME="geth-${PLATFORM}-amd64-${VERSION:1}-${COMMIT:0:8}"
 DOWNLOAD_URL="https://gethstore.blob.core.windows.net/builds/${NAME}.tar.gz"
-curl ${DOWNLOAD_URL} | tar -Oxzf - ${NAME}/geth > ${HOMEDIR}/geth
+TMP_FILE=$(mktemp)
+curl --fail ${DOWNLOAD_URL} | tar -Oxzf - ${NAME}/geth > ${TMP_FILE}
+mv ${TMP_FILE} ${HOMEDIR}/geth
 chmod +x ${HOMEDIR}/geth

main.js

@@ -87,10 +87,17 @@ function downloadClient(client, workdir) {
 
   if (!fs.existsSync(paths.binary)) {
     console.log(`Download latest ${client} version, please wait.`);
-    spawnSync(path.join(__dirname, `get_${client}.sh`), {
+    const childResult = spawnSync(path.join(__dirname, `get_${client}.sh`), {
       env: { HOMEDIR },
       stdio: "inherit"
     });
+    if (childResult.status !== 0) {
+      console.log(
+        `Error downloading ${client}, this might be temporary, ` +
+          `try again later.`
+      );
+      process.exit(childResult.status);
+    }
   }
 }
 
@@ -131,6 +138,10 @@ function provide(client, workdir, allocate, execute, loggingOptions) {
       }
     );
     if (childResult.status !== 0) {
+      console.log(
+        `Error running ${paths.binary}, run it manually to check if it ` +
+          `works or not. If it doesn't, remove it and run ethnode again.`
+      );
       process.exit(childResult.status);
     }
   }

package-lock.json

@@ -6,7 +6,7 @@
   "main": "main.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
-    "install": "ethnode -d"
+    "postinstall": "./cli.js -d"
   },
   "bin": "./cli.js",
   "author": "vrde",