-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoreML conversion fails: "ValueError: Only channel and sequence concatenation are supported." #1
Comments
Hi @galli-leo, Since Coremltools only supports channel-last model, and the model I uploaded is channel-first, I just pushed the channel-first model, you can try it again. CoreML model works very well on iOS devices, it generates exactly the same embeddings as Torch / Keras version, and it runs about 30FPS on iOS devices. Let me know if you have any other questions. Victor |
@iwantooxxoox @galli-leo Is the coreML model available in the repo? Let me know the location otherwise, kindly include it. Thanks. |
@iwantooxxoox That sounds very cool (cannot seem to find the model though :/). Could you also include the changes you made to the coreml source code? I want to try and convert a tenserflow version I found, since it seems to have better accuracy than the openface one. Thus your changes may be helpful :) Anyways, I also tried my luck converting the torch version directly (see: prisma-ai/torch2coreml#9). Unfortunately the numbers are a bit off when comparing torch vs coreml. Just out of curiosity, do you happen to know why that might be? |
@pkwete, @galli-leo, |
Hi,
First of all, thanks for going through all the hassle of converting the model to keras so I don't have to :)
I tried to do the keras to coreml conversion, but it fails with the following error:
Do you have an idea what I could do to fix that? Or would it be possible to send me the converted coreml model directly?
After looking through the notebook again, it seems like you changed the keras / coremltools packge. Can you share those changes / include them in the source?
Additionally, how well does the core ml model work? Did it generate the correct embeddings for the lfw images?
The text was updated successfully, but these errors were encountered: