-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] is work in progress, please let me know if you have any practical suggestions 😉 #421
Comments
Why is this the aim? Vue 2 reached end of life at the end of last year so supporting it seems like a completely unnecessary overhead? |
I just want to try it out and play with After some research, vue-demi is not aimed at component compatibility but is purely logical composable. So if vue-final-modal@5 needs to support both Vue 2 and Vue 3, there may be a lot of duplicate code in the project. I'm not sure if it's worth it. |
Does it still in progress? useTemplate looks great and looking forward to the custom dialog container. Thanks your contribution |
与vue-router绑定? |
Hi. What's the status of the 5.x? I just see a lot of potential places for performance improvements, like reducing the amount of WatchEffect. But I'm not sure if it's worth doing a PR for version 4 now, since a lot of things have already been changed in 5. Also about Vue 2 support, it's clearly not worth it, I'd even say it's better to support Vue from 3.3+ to get |
It would be nice if the onBeforeClose()/onClosed() event provides more information on how the modal was closed (by clicking the overlay, esc key, swipe, useModal().close()) |
In nested modals, it would be nice if we could hide the parent modal so the child modal appears alone but when it is closed, the parent modal is shown again. |
If multiple modals are open it would be good to have the option of automatically raising the z-index of the 'active' modal so it appears above other modals. |
vue-final-modal@5
First of all, I would like to thank all users of vue-final-modal. I learned a lot through creating and maintaining this component library.
I am planing to implement v5 recently. If you have any practical suggestions, please leave a message below.
Roadmap
Features
useDialog()
composable andVueFinalDialog
component based on<dialog />
, see Any thoughts on supporting<dialog />
? #419vue-use-template
that provideContainer
,useTemplate
, etc.useTemplate
composable, can be used to render components without using VueFinalModal.vue. For example:useTemplate
is useful if you want to define a modal yourself with<dialog>
element for example. see Any thoughts on supporting<dialog />
? #419Breaking Change
Replace body-scroll-lock with scroll-lock, see input type="range" is unusable inside modal #403
Rename API
useModalSlot()
todefineTemplate()
and support infinite recursive nested slots touseModal()
. For example:Compatibility
1. For Option API
[email protected]
is for Vue 2,[email protected]
is for Vue 3.2. For Composition API
[email protected]
introduce theuseModal()
composable and fully rewrite with Typescript.[email protected]
support both Vue 2 and Vue 3vue-demi
only because vue-final-modal is not only a composable library but also provide components. The easiest way might be having two split version, but this way I'll have to copy and paste a lot of same codes which I want to avoid. (I'm open to any suggestions)The text was updated successfully, but these errors were encountered: