Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses {# #} instead of <!-- --> for template comments #1352

Closed
pheeque1 opened this issue May 26, 2022 · 6 comments
Closed

Uses {# #} instead of <!-- --> for template comments #1352

pheeque1 opened this issue May 26, 2022 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@pheeque1
Copy link

Issue Type: Bug

When you toggle line comments, the extension uses {# #} instead of <!-- --> for commenting code in Vue SFC template tags.

Extension version: 0.34.16
VS Code version: Code 1.67.2 (Universal) (c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5, 2022-05-17T18:20:57.384Z)
OS version: Darwin arm64 21.3.0
Restricted Mode: No

System Info
Item Value
CPUs Apple M1 (8 x 24)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 6, 5, 4
Memory (System) 16.00GB (0.07GB free)
Process Argv --crash-reporter-id 6e4ab4f6-2ff7-4100-b5dc-ce1fc869657c
Screen Reader yes
VM 0%
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30492333
vscaat:30438848
vsclangdc:30486549

@johnsoncodehk
Copy link
Member

Hi @pheeque1, volar do not provide embedded language comments define, please check if this problem from your other extensions installed.

@johnsoncodehk
Copy link
Member

Duplicate of #388

@johnsoncodehk johnsoncodehk marked this as a duplicate of #388 May 28, 2022
@johnsoncodehk johnsoncodehk added the duplicate This issue or pull request already exists label May 28, 2022
@pheeque1
Copy link
Author

Well, I checked all existing issues including the linked and my situation is different. The output in the description is from bisect which correctly identified volar as the culprit.

When I disable volar, commenting works correctly so maybe a regression makes volar change how comments are defined 🤷🏾 ?

It's only a minor annoyance and I guess I can live with wrong comment formatting given how invaluable volar is for other things.

@johnsoncodehk
Copy link
Member

johnsoncodehk commented May 30, 2022

This is definitely a misunderstanding. 🤦‍♂️ Try open a .html file and do comment, you should see {# #}. (Please don't live with it:) )

@pheeque1
Copy link
Author

pheeque1 commented May 30, 2022

Now I understand better. I trusted bisect a bit too much. I eventually manually narrowed down the offending extension which wasn't volar 🤦🏾‍♂️

Thanks for the pointer :)

@blakegearin
Copy link

blakegearin commented Jul 12, 2023

Thought I'd mention this extension is what was causing this occur for me: Hugo Language and Syntax Support

Related issue: theNewDynamic/language-hugo-vscode#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants