toFirestore inside globalFirestoreOptions.converter is never called

[mrleblanc101]

Reproduction

.

Steps to reproduce the bug

I created this global converter, the fromFirestore gets called, but not the toFirestore.
I see test 2 in the console, but never test 1, and the data in my firestore does not have the field created_at.

globalFirestoreOptions.converter = {
    toFirestore(docData: any) {
        console.log('test 1');
        return {
            created_at: serverTimestamp(),
            ...docData,
        }
    },
    fromFirestore(snapshot: QueryDocumentSnapshot, options: SnapshotOptions): DocumentData {
        console.log('test 2');
        const data = firestoreDefaultConverter.fromFirestore(snapshot)!;
        return data;
    },
};

Expected behavior

Both toFirestore and fromFirestore should be called.

Actual behavior

Only the fromFirestore is called.

Additional information

I want to automatically add a created_at field so that I can sort by date when fetching.

Important: Unlike "push IDs" in the Firebase Realtime Database, Cloud Firestore auto-generated IDs do not provide any automatic ordering. If you want to be able to order your documents by creation date, you should store a timestamp as a field in the documents.
Ref: https://firebase.google.com/docs/firestore/manage-data/add-data?hl=fr

[mrleblanc101]

It works if I use .withConverter instead.
Exemple:

const addDefaultFields = {
    toFirestore(docData: DocumentData): DocumentData {
        console.log('test 1');
        return {
            created_at: serverTimestamp(),
            ...docData,
        }
    },
    fromFirestore(snapshot: QueryDocumentSnapshot, options: SnapshotOptions): DocumentData {
        console.log('test 2');
        const data = firestoreDefaultConverter.fromFirestore(snapshot)!;
        return data;
    },
};

...

async function addProject(option: Project) {
    const project = await addDoc(collection(db, 'projects').withConverter(addDefaultFields), {
        name: option.name,
        user: user.value!.uid,
    })
    return { id: project.id, name: option.name };
}

[posva]

You need to do .withConverter(). VueFire cannot add that for you. It only applies to useDocument() and others from vuefire

[mrleblanc101]

I'm not quite sure I understand, I thought globalFirestoreOptions.converter was a way to define a global converter.

[mrleblanc101]

Oh I think it get it, addDoc is from firebase directly while useDocument is from vue-fire. So globalFirestoreOptions.converter only affect vue-fire call and not firebase call

[mrleblanc101]

So if I understand correctly the globalFirestoreOptions.converter.toFirebase is never called since you can't push data using vue-fire as you need to use the firebase addDoc, updateDoc function directly 🤔