Notification never disappearing

[pmanole-volvocars]

The below code shows a notification that never disappears and only removes it on success.

What I am experiencing is that package-info is failing to determine that the operation succeeded and never removes the notification, which is really annoying because I have to manually dismiss all notifications all the time. Would have been nice if it was using a disappearing notification variant.

I'd have opened a PR myself but my Lua is a bit "rusty" (actually it's crap, and I don't know the NVIM APIs, sort of a novice user...).

package-info.nvim/lua/package-info/actions/show.lua

Lines 32 to 55 in 3de4f35

	job({
	json = true,
	command = "npm outdated --json",
	ignore_error = true,
	on_start = function()
	loading.start(id)
	end,
	on_success = function(outdated_dependencies)
	state.dependencies.outdated = outdated_dependencies
	if vim.api.nvim_buf_is_valid(state.buffer.id) and vim.api.nvim_buf_is_loaded(state.buffer.id) then
	parser.parse_buffer()
	virtual_text.display()
	reload()
	end
	loading.stop(id, loading_message)
	state.last_run.update()
	end,
	on_error = function()
	loading.stop(id, loading_message, vim.log.levels.ERROR)
	end,
	})

Could you add an option to disable notifications as a simple solution to this?

-- Disabling because it shows a never disappearing notification.
---@type LazyPluginSpec
return {
  "vuki656/package-info.nvim",
  opts = {
    hide_unstable_versions = true,
    package_manager = "pnpm",
    -- hide_notifications = true, -- <-- add support for
  },
}

[rami3l]

I can observe the same bug. It looks like this code is simply trying to run npm outdated --json. (Also, it seems that this isn't respecting package_manager = "pnpm", is this intentional?)

If I execute this command manually, it'll terminate in less than a second, so I guess there's probably something wrong with output detection... But an option to disable this notification would be helpful nonetheless.

[vuki656]

Hey, sorry for the late reply

@pmanole-volvocars feel free to open a rough PR and I can guide to trough things if needed and help out

[vuki656]

Can you test https://github.com/vuki656/package-info.nvim/tree/feat/option-to-disable-notifications and see if it works?

[khaneliman]

Trying out the patch in my build doesn't seem to change anything. Still see the notification on load and it doesn't auto dismiss even with:

require("package-info").setup({ hide_up_to_date = true, notifications = false })

[MacMannes]

I tried out this branch, but I noticed there are two notifications when I use notifications = true and only one when I use notifications = false, so it seems the notification is sent two times for some reason.

[vuki656]

Any luck with #165 getting merged and addingt this #165 (comment) ?

[khaneliman]

Looks like the issue doesn't happen for me anymore. The notification goes away now. (Spinner is broken, but that doesn't bother me as much as a persistent notification)