Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetMany implementation considerations #2

Open
i-norden opened this issue Aug 7, 2023 · 0 comments
Open

GetMany implementation considerations #2

i-norden opened this issue Aug 7, 2023 · 0 comments

Comments

@i-norden
Copy link

i-norden commented Aug 7, 2023

We have a tentative GetMany interface and implementation in #1

If some of the CIDs it attempts to retrieve are not found, it currently notes the missing CIDs in a list and returns it along with a list containing the blocks it could find. In such cases where there are missing CIDs, the position of the blocks in the results slice returned will no longer be aligned with the position of the corresponding CID in the list of CIDs provided as argument. This works fine in our current usage, but we may want to consider instead including empty results into the returned results slice so that the blocks returned always have the same index as their corresponding CID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant