Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Venom parser uses slow earley algorithm #4417

Open
charles-cooper opened this issue Dec 20, 2024 · 2 comments
Open

Venom parser uses slow earley algorithm #4417

charles-cooper opened this issue Dec 20, 2024 · 2 comments
Labels
Easy Pickings Used to denote issues that should be easy to implement help wanted performance Issue related to compile-time performance venom

Comments

@charles-cooper
Copy link
Member

Version Information

  • vyper Version (output of vyper --version): v0.4.1b3

What's your issue about?

The venom parser (

vyper/vyper/venom/parser.py

Line 67 in 9c98b3e

VENOM_PARSER = Lark(VENOM_GRAMMAR)
) is currently slow as it uses lark's "earley" algorithm (https://lark-parser.readthedocs.io/en/latest/parsers.html#earley). Switch to LALR(1)
@charles-cooper charles-cooper added help wanted Easy Pickings Used to denote issues that should be easy to implement venom labels Dec 20, 2024
@charles-cooper charles-cooper changed the title Venom parser is slow Venom parser uses slow earley algorithm Dec 20, 2024
@charles-cooper charles-cooper added the performance Issue related to compile-time performance label Dec 20, 2024
@tav-singh
Copy link

Hi @charles-cooper, I can pick this up.

@charles-cooper
Copy link
Member Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Pickings Used to denote issues that should be easy to implement help wanted performance Issue related to compile-time performance venom
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charles-cooper @tav-singh