Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the feature selection #16

Open
ChairManMeow-SY opened this issue Jun 20, 2022 · 1 comment
Open

About the feature selection #16

ChairManMeow-SY opened this issue Jun 20, 2022 · 1 comment

Comments

@ChairManMeow-SY
Copy link

ChairManMeow-SY commented Jun 20, 2022

Hi,

I wonder if we need first normalize the features before using the sequential feature selection. As the regression model takes SVR, which requires the normalized input.

I checked the source code. The SFS will not automatically call the minmax norm within it. I notice in your script the SFS input is not normalized. Why ?

@vztu
Copy link
Owner

vztu commented Jul 25, 2022

Hmm, good point. I think I might have done it wrong. But telling from my final results, it didn't affect too much. Applying normalization before each iteration should be more rigorous. Actually every time you run feature selection, you will get a different resulting model. All these models should give similar performance, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants