Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should test properly signed but invalid Verifiable Credentials #26

Open
msporny opened this issue Sep 9, 2022 · 0 comments
Open
Assignees

Comments

@msporny
Copy link
Contributor

msporny commented Sep 9, 2022

Most of the tests modify a properly signed data structure, which means that verifiers will (properly) reject the signature because its invalid. What we want instead is for the verifiers to reject the data structure because the data structure is invalid. In each test below here, we should modify the property under test to an invalid value and then properly sign it, and then send it to the verifier. The verifier should detect a valid signature, but fail the item because of the invalid property. We should also keep proper positive and negative tests for a valid signature.

"We need to be checking two classes of failure. One - this VC which has a valid signature does not conform to the VC data model, and two - this VC that conforms to the data model has an invalid signature." -- @brownoxford

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants