Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetchEvent: add origin check before setting replacesClientId #1679

Open
gterzian opened this issue May 17, 2023 · 1 comment
Open

FetchEvent: add origin check before setting replacesClientId #1679

gterzian opened this issue May 17, 2023 · 1 comment

Comments

@gterzian
Copy link

As part of implementing replacesClientId, the issue of what to do in the event of a cross-origin navigation came up. In such a case, replacesClientId will be the id of a client whose origin is different from the service worker handling the fetch event.

So, it feels as if Step 24.3.9 of Handle Fetch should include a same origin check and initialize replacesClientId to the empty string if it fails?

I can also write additional tests for this specific situation as part of WebKit/WebKit#13130

@gterzian
Copy link
Author

cc @youennf

@gterzian gterzian changed the title FetchEvent: Add origin check before setting replacesClientId FetchEvent: add origin check before setting replacesClientId May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant