Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Undoing Blocks, and maybe reading back Blocks #240

Closed
puckipedia opened this issue Jul 3, 2017 · 6 comments
Closed

Document Undoing Blocks, and maybe reading back Blocks #240

puckipedia opened this issue Jul 3, 2017 · 6 comments

Comments

@puckipedia
Copy link

Currently, the spec says nothing about Undos on Blocks. Maybe it's also an idea to have a (private) collection of blocked people, so you can look back who is blocked? (I kinda implemented this in Kroeg already... :P)

@puckipedia
Copy link
Author

Implementation update: Due to how Undo's work, I replaced the blocked collection in Kroeg with blocks, which is a list of Block Activities. I still have a blocked list internally, but it's blocked (hehe) off so it isn't readable from the user.

@cwebber
Copy link
Collaborator

cwebber commented Jul 25, 2017

Specifying Undoing Blocks seems reasonable. At least you could say that it undoes the blocking of side effects of future actions.

I think having an actor privately having a blocked property makes sense, and indeed I also implement such a collection in ActivityPub. One issue is that, how do you discover it? I don't actually have the blocked property on my actors because it seems... weird, even if it's a private collection.

@cwebber
Copy link
Collaborator

cwebber commented Jul 25, 2017

I'll make a change along these lines:

<eprodrom> "For example, Undo may be used to undo a previous Like or Follow."                                         
           -> "For example, Undo may be used to undo a previous Like, Follow                                          
           or Block."

@cwebber
Copy link
Collaborator

cwebber commented Jul 25, 2017

I'll write up some wording for adding a private blocked collection for next week.

@rhiaro
Copy link
Member

rhiaro commented Oct 28, 2017

blocked and blocks collections sound like extensions at this point, what say ye @cwebber? To the CG..?

@cwebber
Copy link
Collaborator

cwebber commented Oct 28, 2017

I think so! Conversation continued here: swicg/general#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants