Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page: multiple header elements #2350

Closed
shirsha opened this issue May 22, 2022 · 3 comments
Closed

Home page: multiple header elements #2350

shirsha opened this issue May 22, 2022 · 3 comments
Labels
Feedback Issue raised by or for collecting input from people outside APG task force

Comments

@shirsha
Copy link

shirsha commented May 22, 2022

  • On the home page there are several issues with the landmarks:
    • All content is not placed inside the landmark. For example, the banner content is not placed inside an header element.
    • An header element is used inside the aside landmark which contains the heading " Help improve this page.
    • The main content is placed inside the header element.
    • There is an empty footer element on the page.
@mcking65
Copy link
Contributor

@shirsha
The only feedback I understand in this issue is the missing banner landmark, which is dependent on w3c/wai-minimal-header-design#96.

I opened a separate wai/apg site issue to track the banner issue and dependency on the templat: w3c/wai-aria-practices#106.

I don't know what to do about the other feedback you are providing in this issue because there is not enough information to identify a problem. Will you please raise separate issues for each, and please provide code snippets or more detail so we can understand what the problem is?

@mcking65 mcking65 added the Feedback Issue raised by or for collecting input from people outside APG task force label May 23, 2022
@shirsha
Copy link
Author

shirsha commented May 26, 2022

@mcking65
My statements got messed up as I was using chevrons for header and footer elements.
I have removed them from my initial comments.
Sorry for the confusion

Thanks,
Siri

@isaacdurazo
Copy link
Member

This seems to be solved. @shirsha please feel free to re-open if I'm mistaken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Issue raised by or for collecting input from people outside APG task force
Projects
None yet
Development

No branches or pull requests

3 participants