Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that examples are properly explained #125

Closed
msporny opened this issue Nov 17, 2024 · 2 comments
Closed

Ensure that examples are properly explained #125

msporny opened this issue Nov 17, 2024 · 2 comments
Assignees
@msporny
Labels
during CR This issue will be addressed during Candidate Recommendation editorial This item is editorial in nature. pr exists A Pull Request exists to address this issue.

Comments

@msporny
Copy link
Member

msporny commented Nov 17, 2024

Some of the examples in the specification contain no explanation and some might benefit from an explanation of what the example is showing.
@msporny msporny added editorial This item is editorial in nature. during CR This issue will be addressed during Candidate Recommendation labels Nov 17, 2024
@msporny msporny self-assigned this Nov 17, 2024
@msporny msporny mentioned this issue Nov 17, 2024
Merged
@msporny msporny added the ready for pr This issue is ready to have a pull request created for it. label Nov 17, 2024
@msporny msporny mentioned this issue Jan 12, 2025
Merged
@msporny
Copy link
Member Author

msporny commented Jan 12, 2025

PR #143 has been raised to address this issue. This issue will be closed once PR #143 has been merged.

@msporny msporny added pr exists A Pull Request exists to address this issue. and removed ready for pr This issue is ready to have a pull request created for it. labels Jan 12, 2025
@msporny
Copy link
Member Author

msporny commented Jan 20, 2025

PR #143 has been merged, closing.

@msporny msporny closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
during CR This issue will be addressed during Candidate Recommendation editorial This item is editorial in nature. pr exists A Pull Request exists to address this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msporny