-
Notifications
You must be signed in to change notification settings - Fork 707
[css-view-transitions-2] view-transition-name: auto when matching id should namespace #11614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this makes sense |
I'm personally happy to resolve on this, perhaps asynchronously since WG meeting time is hard to get. /cc @jakearchibald |
I still think this is a bad feature with a bad name. But it was force-shipped. |
Is this name exposed to the developer or does it just look like the transition is named auto? If it's exposed, what is the name it's exposed as? |
It should not be exposed, as per previous resolutions it would be |
I actually thought this is the behavior we had adopted already. :) I.e. that the ID was used only internally for pairing elements, not otherwise exposed as a view-transition-name. |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> vmpstr: we added v-t-name:auto<TabAtkins> vmpstr: matches the VT name based on the element's ID attribute, and acts as match-element otherwise <TabAtkins> vmpstr: this name isn't exposed anywhere, it's "auto" in serializations <TabAtkins> vmpstr: but wanted to clarify that the ID ident shouldn't match another VT that specifies a manual ident that happens tob e the same <TabAtkins> vmpstr: Like `v-t-name: foo` on one element and `v-t-name:auto` on an element with id="foo" shouldn't match <TabAtkins> astearns: looks like there's agreement in the thread <TabAtkins> sounds fine to me <TabAtkins> astearns: anyone in the room actually want the behavior we're prohibiting? <TabAtkins> no opinion either way, really, happy to defer to editors <bkardell_> makes sense <noamr> +1 <TabAtkins> fantasai: I thought that's what we'd adopted originally, that the ID would only be used to link elements together, not something exposeable to other CSS. So this makes sense to me. <TabAtkins> vmpstr: proposed: v-t-name:auto will never match an explicit v-t-name:<ident> <TabAtkins> astearns: any objections? <TabAtkins> RESOLVED: v-t-name:auto never matches an explicit v-t-name:<ident> |
…only match other IDs Closes w3c#11614
We have a
view-transition-name: auto
that can use theid
attribute from the element as the view transition name. (https://www.w3.org/TR/css-view-transitions-2/#auto-vt-name)I think it can be confusing if, for example, in the old state we match
id=foo
and on the other side that pairs with cssview-transition-name: foo
.The proposal is to "namespace" id matching. Basically
id=foo
would only match withid=foo
and not withview-transition-name: foo
. Or, in other words, names generated by theid
attribute can only match elements that have names that are also generated by theid
attribute.@nt1m @noamr fyi
The text was updated successfully, but these errors were encountered: