Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing term in the vcdm spec #1216

Closed
iherman opened this issue Jul 26, 2023 · 6 comments
Closed

Missing term in the vcdm spec #1216

iherman opened this issue Jul 26, 2023 · 6 comments
Assignees

Comments

@iherman
Copy link
Member

iherman commented Jul 26, 2023

As reported in #1209, the serviceEndpoint term, though present in the vocabulary, does not have a formal specification in the VCDM specification (nor in the DID specification, although it has been suggested that this may be a DID related term).

@iherman iherman self-assigned this Jul 26, 2023
@iherman iherman changed the title Missing term in the credentials vocabulary Missing term in the vcdm spec Jul 26, 2023
@brentzundel
Copy link
Member

The definition I know of is here: https://www.w3.org/TR/did-core/#service-endpoints

@iherman
Copy link
Member Author

iherman commented Aug 1, 2023

I am happy to use that URL and be over with it, but it is a little bit strange to see this term in this vocabulary.

However, this is a layman's reaction. If there is an agreement to use that, I will make a PR for this.

cc @msporny @dlongley

@iherman
Copy link
Member Author

iherman commented Aug 11, 2023

Note #1230. If that PR is accepted and merged, it makes this issue moot, ie, can be closed.

@msporny
Copy link
Member

msporny commented Aug 11, 2023

As @brentzundel noted above... this is how we defined service and serviceEndpoint in DID Core... which shows that both of those terms are defined in the DID Core vocabulary, not the security vocabulary.

    "service": {
      "@id": "https://www.w3.org/ns/did#service",
      "@type": "@id",
      "@context": {
        "@protected": true,
        "id": "@id",
        "type": "@type",
        "serviceEndpoint": {
          "@id": "https://www.w3.org/ns/did#serviceEndpoint",
          "@type": "@id"
        }
      }
    },

IOW, I think we can close this issue because service and serviceEndpoint isn't defined by the security vocabulary.

@iherman
Copy link
Member Author

iherman commented Aug 11, 2023

IOW, I think we can close this issue because service and serviceEndpoint isn't defined by the security vocabulary.

Which means merging #1230 ...

@iherman
Copy link
Member Author

iherman commented Aug 14, 2023

#1230 has been merged, I will close this comment.

@iherman iherman closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants