Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-review test language which should match spec language #48

Open
TallTed opened this issue Jul 3, 2024 · 2 comments
Open

re-review test language which should match spec language #48

TallTed opened this issue Jul 3, 2024 · 2 comments

Comments

@TallTed
Copy link
Member

TallTed commented Jul 3, 2024

Originally posted by @aljones15 in #33 (comment)

@TallTed as this PR is part of a chain with other tests in it perhaps we should merge this as is and fix once that issue has been addressed and the group can agree on consensus on spec text? The big issue I'm running into here is that there are 4 more PRs branched from this branch which build on the features uses in this PR, and some of those PRs contain tests and features that would improve main and make the suite extensible. So it seems like we need to monitor and update test titles more.

Also see w3c/vc-di-bbs#178

@TallTed TallTed mentioned this issue Jul 3, 2024
1 task
@aljones15
Copy link
Contributor

@TallTed thank you for the issue, I am making a note to review the spec text on Friday if I miss the changes. How to keep these suites in touch with the existing specs is known problem we're working on.

@aljones15
Copy link
Contributor

This PR addressed some of the discrepancy between spec and test suite titles: #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants