Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enumerated elements should match the counts of those elements #64

Open
TallTed opened this issue Oct 22, 2024 · 1 comment
Open

enumerated elements should match the counts of those elements #64

TallTed opened this issue Oct 22, 2024 · 1 comment

Comments

@TallTed
Copy link
Member

TallTed commented Oct 22, 2024

Originally posted by @TallTed in #63 (comment)

The first paragraph of 3.3.7 parseDerivedProofValue

A single derived proof value object is produced as output, which contains a set of six or seven elements, having the names "bbsProof", "labelMap", "mandatoryIndexes", "selectiveIndexes", "presentationHeader", "featureOption", and, depending on the value of the featureOption parameter, "pseudonym" and/or "lengthBBSMessages".

— is internally inconsistent (the set may have six, seven, or eight elements) and it disagrees with the last paragraph of that algorithm (again, should say "six, seven, or eight elements" including "featureOption", "pseudonym" and/or "lengthBBSMessages") —

Return derived proof value as an object with properties set to the five, six, or seven elements, using the names "bbsProof", "labelMap", "mandatoryIndexes", "selectiveIndexes", "presentationHeader", and optional "pseudonym" and/or "lengthBBSMessages", respectively. In addition, add featureOption and its value to the object.

These should be brought into agreement. Whatever the result is, it should then be applied to this part of the test suite.

@TallTed
Copy link
Member Author

TallTed commented Oct 22, 2024

This should probably be moved to the https://github.com/w3c/vc-di-bbs/ repo. (I can't, or I would.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant