Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous text in the HKDF derive bits operation #372

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

twiss
Copy link
Member

@twiss twiss commented Oct 21, 2024

Fixes #371.


Preview | Diff

Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, so I approve :)

But I'm not sure whether my vote counts here, afterall I reported the issue originally.

@twiss
Copy link
Member Author

twiss commented Oct 25, 2024

Counts in my book, thanks! :)

@twiss twiss merged commit 4c8ebc7 into main Oct 25, 2024
2 checks passed
@twiss twiss deleted the remove-superfluous-hkdf-text branch October 25, 2024 08:14
github-actions bot added a commit that referenced this pull request Oct 25, 2024
SHA: 4c8ebc7
Reason: push, by twiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
BenWiederhake added a commit to BenWiederhake/ladybird that referenced this pull request Oct 25, 2024
This corresponds to a recent change in the spec:
w3c/webcrypto#372
Inspired by the following review comment:
LadybirdBrowser#1877 (comment)
gmta pushed a commit to LadybirdBrowser/ladybird that referenced this pull request Oct 25, 2024
This corresponds to a recent change in the spec:
w3c/webcrypto#372
Inspired by the following review comment:
#1877 (comment)
Grubre pushed a commit to Grubre/ladybird that referenced this pull request Oct 26, 2024
This corresponds to a recent change in the spec:
w3c/webcrypto#372
Inspired by the following review comment:
LadybirdBrowser#1877 (comment)
nico pushed a commit to nico/serenity that referenced this pull request Nov 12, 2024
This corresponds to a recent change in the spec:
w3c/webcrypto#372
Inspired by the following review comment:
LadybirdBrowser/ladybird#1877 (comment)

(cherry picked from commit ee3b86c3f87d8a44ba92c8aaff75925948ceacfd)
nico pushed a commit to nico/serenity that referenced this pull request Nov 12, 2024
This corresponds to a recent change in the spec:
w3c/webcrypto#372
Inspired by the following review comment:
LadybirdBrowser/ladybird#1877 (comment)

(cherry picked from commit ee3b86c3f87d8a44ba92c8aaff75925948ceacfd)
nico pushed a commit to SerenityOS/serenity that referenced this pull request Nov 12, 2024
This corresponds to a recent change in the spec:
w3c/webcrypto#372
Inspired by the following review comment:
LadybirdBrowser/ladybird#1877 (comment)

(cherry picked from commit ee3b86c3f87d8a44ba92c8aaff75925948ceacfd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HKDF: Step computes unused variable "extractKey"
2 participants