Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set [[usages]] and [[extractable]] in the deriveKey method #384

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

panva
Copy link
Member

@panva panva commented Nov 15, 2024

Closes #383
Refs LadybirdBrowser/ladybird#2354

This is now the same as for unwrapKey and importKey


Preview | Diff

@panva panva changed the title set usages and extractable during deriveKey set usages and extractable in the deriveKey method Nov 15, 2024
@panva panva changed the title set usages and extractable in the deriveKey method set [[usages]] and [[extractable]] in the deriveKey method Nov 15, 2024
@twiss
Copy link
Member

twiss commented Nov 15, 2024

Thanks for the PR! Since it's copied from elsewhere, I think it could be considered non-substantive for the purpose of IPR; if you agree, could you mark it as such here?

@w3cbot
Copy link

w3cbot commented Nov 15, 2024

panva marked as non substantive for IPR from ash-nazg.

@w3cbot
Copy link

w3cbot commented Nov 15, 2024

panva marked as substantive for IPR from ash-nazg.

@panva
Copy link
Member Author

panva commented Nov 15, 2024

panva did not make IPR commitments for this group. To make the IPR commitments, panva should join the Web Application Security Working Group .

That's no longer the case, I have joined the working group through my organization, revalidate doesn't seem to kick in though.

@w3cbot
Copy link

w3cbot commented Nov 15, 2024

panva marked as non substantive for IPR from ash-nazg.

@twiss twiss merged commit b21575f into w3c:main Nov 15, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Nov 15, 2024
SHA: b21575f
Reason: push, by twiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
gmta added a commit to gmta/ladybird that referenced this pull request Nov 15, 2024
Our spec issue got resolved, including a bonus fix!

See: w3c/webcrypto#384
awesomekling pushed a commit to LadybirdBrowser/ladybird that referenced this pull request Nov 15, 2024
Our spec issue got resolved, including a bonus fix!

See: w3c/webcrypto#384
gotlougit pushed a commit to gotlougit/ladybird that referenced this pull request Nov 21, 2024
Our spec issue got resolved, including a bonus fix!

See: w3c/webcrypto#384
nico-engels pushed a commit to nico-engels/ladybird that referenced this pull request Nov 23, 2024
Our spec issue got resolved, including a bonus fix!

See: w3c/webcrypto#384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extractable property not set in SubtleCrypto.deriveKey
3 participants