diff --git a/evaluations/ink-analyzer-phase-2_7_keeganquigley.md b/evaluations/ink-analyzer-phase-2_7_keeganquigley.md index 3cc18aa07..cc79481ad 100644 --- a/evaluations/ink-analyzer-phase-2_7_keeganquigley.md +++ b/evaluations/ink-analyzer-phase-2_7_keeganquigley.md @@ -1,6 +1,6 @@ # Evaluation -- **Status:** In progress +- **Status:** Accepted - **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/ink-analyzer-phase-2.md - **Milestone:** 7 - **Previously successfully merged evaluation:** All by keeganquigley @@ -10,31 +10,29 @@ | Number | Deliverable | Accepted | Link | Notes | |---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | **0a.** | License | | [GPL-3.0](https://github.com/ink-analyzer/ink-vscode/blob/master/LICENSE). | | -| **0b.** | Documentation | | [Visual Studio Code Extension README](https://github.com/ink-analyzer/ink-vscode/blob/master/README.md), [Development, Debugging and Automated Testing](https://github.com/ink-analyzer/ink-vscode/blob/master/DEVELOPMENT.md) and [Manual Feature Testing](https://github.com/ink-analyzer/ink-vscode/blob/master/TESTING.md) guides on GitHub, and extensive inline source documentation in the [Github repository](https://github.com/ink-analyzer/ink-vscode/). | | -| **0c.** | Testing and Testing Guide | | [Development, Debugging and Automated Testing](https://github.com/ink-analyzer/ink-vscode/blob/master/DEVELOPMENT.md) and [Manual Feature Testing](https://github.com/ink-analyzer/ink-vscode/blob/master/TESTING.md) guides. | | -| **0d.** | Docker | | [Dockerfile](https://github.com/ink-analyzer/ink-vscode/blob/master/.devcontainer/devcontainer.json). | | -| **0e.** | Article | | [Article](https://analyze.ink/blog/ink-analyzer-updates). | | -| 1. | Visual Studio Code Extension: Update extension to support ink! language support features added to the semantic analyzer and language server in milestones 1, 2, 3, 4, 5 and 6 | | [GitHub repository](https://github.com/ink-analyzer/ink-vscode). | | +| **0b.** | Documentation | | [Visual Studio Code Extension README](https://github.com/ink-analyzer/ink-vscode/blob/master/README.md), [Development, Debugging and Automated Testing](https://github.com/ink-analyzer/ink-vscode/blob/master/DEVELOPMENT.md) and [Manual Feature Testing](https://github.com/ink-analyzer/ink-vscode/blob/master/TESTING.md) guides on GitHub, and extensive inline source documentation in the [Github repository](https://github.com/ink-analyzer/ink-vscode/). | Extensive docs. | +| **0c.** | Testing and Testing Guide | | [Development, Debugging and Automated Testing](https://github.com/ink-analyzer/ink-vscode/blob/master/DEVELOPMENT.md) and [Manual Feature Testing](https://github.com/ink-analyzer/ink-vscode/blob/master/TESTING.md) guides. | All pass. | +| **0d.** | Docker | | [Dockerfile](https://github.com/ink-analyzer/ink-vscode/blob/master/.devcontainer/devcontainer.json). | Runs. | +| **0e.** | Article | | [Article](https://analyze.ink/blog/ink-analyzer-updates). | Good. | +| 1. | Visual Studio Code Extension: Update extension to support ink! language support features added to the semantic analyzer and language server in milestones 1, 2, 3, 4, 5 and 6 | | [GitHub repository](https://github.com/ink-analyzer/ink-vscode). | Good. | # General Notes -Mostly working great! Code completion works. Initializes nicely w/ rust-analyzer. Hover pop-ups work for both rust-analyzer and ink-analyzer: +UPDATE: All issues were [resolved](https://github.com/ink-analyzer/ink-vscode/commit/40ae89f3c3088a1e793c6ab09a642339eddeeaca) by grantee. + +Working great! Code completion works. Diagnostics, signature help, quick fixes, command palette all works as expected. I can sucessfully stop and restart the language server. Initializes seamlessly alongside rust-analyzer. Hover pop-ups work for both rust-analyzer and ink-analyzer: test1 test2 -For some reason I can't get the hints to display in the command palette: - -palette - Correctly displays errors and inlay hints: inlay # Tests -Test is failing for `non-packed-tuple-struct` is this intended behavior? +~~Test is failing for `non-packed-tuple-struct` is this intended behavior?~~ Issue resolved. e2e tests work great and good coverage. Debugging manually also works.
Output